zseder / hunvec

Sequential Tagging in NLP using neural networks
5 stars 4 forks source link

TaggedCorpus refactoring #68

Closed zseder closed 9 years ago

zseder commented 9 years ago

TaggedCorpus should be split into RawCorpus and TaggedCorpus

zseder commented 9 years ago

one additional info: no code copying should be used, only code reusing, for example with a good design, add_features can be implemented in a way that it can work with RawCorpus and TaggedCorpus, without a change, so it is enough to do that in RawCorpus. Hint:

new_sen = [word_data + [self.featurizer.featurize(word_data[0])] for word_data in sen]
zseder commented 9 years ago

done in #70