search

zserge / jsmn

Jsmn is a world fastest JSON parser/tokenizer. This is the official repo replacing the old one at Bitbucket
MIT License
3.68k stars 783 forks source link

Cmake build #54

Open scanban opened 9 years ago

scanban commented 9 years ago

added cmake build.

zserge commented 9 years ago

What are the benefits of CMake for a library like jsmn?

AFAIK, most JSMN users simply copy jsmn.c and jsmn.h into their projects with their own build system, while for this repository good old Makefiles seem to be working well (it's just one C file to compile and no dependencies!).

I understand the benefits of moving from autotools to CMake, but from a simple Makefile to a tool that generates a complex Makefile.. I'm not sure.

scanban commented 9 years ago

Hello,

first of all, thank you for the very good library. I'm going to use it in some of my projects. cmake is doing good job for me for building projects on multiple platform/compiler combinations. As I can see, many projects now offers at least cmake alternative build in additions to autotools.

Last but not least, cmake used as build system in CLion https://www.jetbrains.com/clion/, very good C/C++ IDE.

On 17 October 2015 at 16:07, Serge Zaitsev notifications@github.com wrote:

What are the benefits of CMake for a library like jsmn?

AFAIK, most JSMN users simply copy jsmn.c and jsmn.h into their projects with their own build system, while for this repository good old Makefiles seem to be working well (it's just one C file to compile and no dependencies!).

I understand the benefits of moving from autotools to CMake, but from a simple Makefile to a tool that generates a complex Makefile.. I'm not sure.

— Reply to this email directly or view it on GitHub https://github.com/zserge/jsmn/pull/54#issuecomment-148918146.

With best regards, Stanislav.

fire commented 8 years ago

Having a cmake file means any cmake project author can keep the jsmn project as full project in source control, copying the jsmn.c and jsmn.h destroys the history.

Yes, it's possible for to add cmake as scanban has done, but it means maintaining a fork.

pt300 commented 5 years ago

Now that library is just a .h file the build system isn't that crucial any more. It's still nice to consider it for building examples and testing. (use of ctest)