search

zserge / lorca

Build cross-platform modern desktop apps in Go + HTML5
MIT License
8k stars 532 forks source link

remove `--enable-automation` flag to disable browser is controlled message #169

Open bin16 opened 2 years ago

bin16 commented 2 years ago

detail: https://github.com/zserge/lorca/issues/167#issuecomment-1046045388

cgostuff commented 2 years ago

Simply removing this flag will cause the "save password" bubble to pop up again unfortunately.

christopher-kleine commented 2 years ago

@cgostuff If a user needs passwords, it can be added later. This seems to be the more reasonable default. There are cases where the message "The browser is controlled" is a deal breaker.

cgostuff commented 2 years ago

@christopher-kleine I believe one of the main uses of webviews like this library is a login flow for desktop applications. Consequently I think that the "save password" bubble popping up every time you log in with Lorca is equally a deal breaker. Both should be possible to disable at the same time.

georgemcarlson commented 2 years ago

@cgostuff This is the more reasonable default. The ui.New function is written to allow users to add in additional custom arguments but does not allow the user to restrict defined default arguments. With this change users that need to not have the banner will not have the banner and users that want to not have the "save password" bubble can still supply the parameter to not have the "save password" bubble.

cgostuff commented 2 years ago

@georgemcarlson I agree, having this configurable is better. I will open a new issue about the "save password" bubble, surely there must be some programmatic way of disabling it other than command line switches.

georgemcarlson commented 2 years ago

I made an alternate pull request here that should accommodate everyone. It leaves the current lorca UI constructor implementation intact and creates two new lorca UI constructors (lorca.NewChromium and lorca.NewEdge) which do not automatically include the default arguments. This will let users have more control in the future over what arguments are passed to the lorca UI constructor. https://github.com/zserge/lorca/pull/175