Update parameters for Embed to match definition

zserge / lorca

Build cross-platform modern desktop apps in Go + HTML5

MIT License

8.04k stars 535 forks source link

Update parameters for Embed to match definition #48

Closed lukanus closed 4 years ago

lukanus commented 5 years ago

There is a problem in this file so Embed doesn't take such params : func Embed(file string, dirs ...string) error

HelloKashif commented 5 years ago

Yes I faced the same issue. Embed API has been changed and should also be reflected in the godoc

zserge commented 5 years ago

Is this still relevant? IIRC, Embed() takes package name as the first parameter now, this is what I see in code and in godoc. So the code in gen.go looks valid to me.