zserge / tray

Cross-platform, super tiny C99 implementation of a system tray icon with a popup menu.
MIT License
504 stars 86 forks source link

Add platform-specific examples and update readme #2

Closed jesselawson closed 7 years ago

jesselawson commented 7 years ago

I wanted to provide a quick and easy way to get up and running immediately once this is downloaded, and I also wanted to update the readme to include some more helpful information about how to get started with this. Great work!

zserge commented 7 years ago

I agree with a more developer-friendly readme, but I can't see how splitting code into 3 almost identical C files would help. The whole idea was that you can have one common code for all 3 platforms. I think it would be more useful to make something like #ifdef WIN32 etc in one file to detect OS automatically and build the code for that platform. Otherwise, if I saw that I need to write 3 different files for 3 different platforms to use a cross-platform library - I'd probably be scared away.

jesselawson commented 7 years ago

. Otherwise, if I saw that I need to write 3 different files for 3 different platforms to use a cross-platform library - I'd probably be scared away.

Yep, good point. The #ifdef makes a lot more sense. The lack of sleep is catching up to me.

zserge commented 7 years ago

I've noticed that there's been some messed-up text in README, so I cleaned it up. Thanks for the pull request!