search

zsh-users / antigen

The plugin manager for zsh.
http://antigen.sharats.me
MIT License
8.09k stars 280 forks source link

Fix deferred compdef between sourcing antigen and antigen apply #737

Open segevfiner opened 2 years ago

segevfiner commented 2 years ago

Using some obscure Zsh syntax, check https://zsh.sourceforge.io/Doc/Release/Expansion.html#Parameter-Expansion-Flags for documentation about it.

Fixes #736

segevfiner commented 2 years ago

This seems to only fix the no/stale cache case, when the cache is enabled, there is no compdef between sourcing antigen and apply, during applying the cache and after it is set to a no-op compdef and only set to the real compdef after the delayed compinit runs on the first prompt.

segevfiner commented 2 years ago

Modified so it also fixes the caching case.

mr-narender commented 2 years ago

Can this be reviewed and unblocked for merge please. Impacted from https://github.com/zsh-users/antigen/issues/736

segevfiner commented 2 years ago

Sadly this project seems unmaintained for quite some time and the original maintainers haven't appointed anyone new to take over.

segevfiner commented 2 years ago

If you want to manually patch your local antigen install: antigen-deferred-compdef-fix.patch.tar.gz

 patch -p2 -i antigen-deferred-compdef-fix.patch
donhector commented 1 year ago

Thank you for your fix @segevfiner! It's a pity this project no longer seems maintained.