search

zsh-users / zsh-autosuggestions

Fish-like autosuggestions for zsh
MIT License
30.43k stars 1.85k forks source link

Add Fig as an installation method to the README #692

Closed ibayramli closed 10 months ago

ibayramli commented 2 years ago

The Fig Plugin Store supports 1-click install for 400+ shell plugins. We have over 100k users, thousands of whom manage their shell configuration with Fig.

Zsh Autosuggest is already listed in the store so we'd love to have it listed as a download method on your readme.

Thanks so much and please let me know if you have any questions!

z0rc commented 2 years ago

@ibayramli2001 please tone down the wording. This isn't a place to advertise Fig and its features.

Also you're using same template with advertisement text for PRs in multiple repos. Please stop using it.

ericfreese commented 2 years ago

Pretty much agreed with @z0rc. I'm ok with listing it here but let's skip the marketing talk and have just a link to the fig plugin page, something along these lines is fine.

Out of curiosity, doesn't the functionality from the plugin kind of clash with Fig's autocompletion? Do they actually work well together?

ibayramli commented 2 years ago

Thanks for reviewing this @ericfreese. Although currently the button links to a plugin store webpage, it will soon redirect the link to open up zsh-autosuggestions plugin store page in desktop for Fig users. It is more clear to have a button open up a desktop app than a hyperlink, so we would strongly prefer to have a button.

Re zsh autosuggest and Fig autocomplete conflicts, I would say they complement each other rather than conflict. Here is a demo:

https://user-images.githubusercontent.com/43158991/174156245-5fc858bc-496b-4d72-8660-7126df15dcd6.mov

brendanfalk commented 1 year ago

@ericfreese - My apologies for massive delay here (have just been cleaning out my GH notifications)

I've updated the PR factoring in you commentary above.

Intention is not to be markety or salesy. We truly do have a bunch of users, zsh-autosuggestion is incredibly popular (we feature it heavily in our store), and having us listed as an install method helps other users quickly download it.

Apologies again for the issues above - please let me know if any more questions/concerns!