zsh-users / zsh-completions

Additional completion definitions for Zsh.
Other
6.9k stars 713 forks source link

add trash-d completion #1022

Closed mirsella closed 1 year ago

mirsella commented 1 year ago

https://github.com/rushsteve1/trash-d

thanks !

mirsella commented 1 year ago

thank you for taking the time to improve the completion file, and comment your changes.

I think you deserve to add yourself to the authors list if you want :)

syohex commented 1 year ago

Unfortunately I noticed that zsh itself already provides another trash command completion and it is used by default with default setting instead of this completion file. (It is put under Darwin directory, but some Linux distributions set it to fpath)

I'm afraid that I think it is difficult to merge this completion file because

So I think you should write trash completion that works for both macOS implementation and D language implementation and send it to zsh mailing list if you want to use trash command completion.

mirsella commented 1 year ago

Thanks

I opened https://github.com/zsh-users/zsh/pull/99, if it doesn't succeed I'll try to reopen the PR on trash-d