Add jest completion - Githubissues

zsh-users / zsh-completions

Additional completion definitions for Zsh.

Other

6.87k stars 712 forks source link

Add jest completion #1054

Closed aoyama-val closed 10 months ago

aoyama-val commented 10 months ago

[x] This compdef is not already available in zsh.
[x] This compdef is not already available in their original project.
[x] I am the original author, or I have authorization to submit this work.
[x] This is a finished work.
[x] It has a header containing authors, status and origin of the script.
[x] It has a license header or I accept that it will be licensed under the terms of the Zsh license.

syohex commented 10 months ago

Users cannot see a description as above if it is too long. So I think it should be one sentence at most except special cases.In most cases, it is enough to use the first sentence as the flag description. And I think type information is redundant

aoyama-val commented 10 months ago

Thank you for your review. Fixed them. I made the descriptions shorter, but the longest one is still 146 characters long. I don't think that's a real harml, rather benefit for users who have large monitors. What do you think?

syohex commented 10 months ago

I think it's ok. thanks