zsh-users / zsh-completions

Additional completion definitions for Zsh.
Other
6.87k stars 712 forks source link

Completions for fvm are broken as of fvm v3 #1075

Closed bartekpacia closed 4 months ago

bartekpacia commented 4 months ago

Completion script in question: https://github.com/zsh-users/zsh-completions/blob/master/src/_fvm

As of latest fvm v3.0.0, the above completion script doesn't work. Learn more in https://github.com/leoafarias/fvm/issues/689

ping @syohex who created it (huge thank you and kudos!)

syohex commented 4 months ago

Thanks for reporting issue. It seems fvm supports zsh completion itself now. I'll remove fvm completion from this repository according to our policy.

bartekpacia commented 4 months ago

It seems fvm supports zsh completion itself now.

Hmm, does it? What do you mean?

syohex commented 4 months ago

I tried new fvm. It generates completion files(e.g. ~/.dart-cli-completion/fvm.zsh) under ~/.dart-cli-completion/ and it appends its configuration in the zsh configuration file(.zshrc etc)

bartekpacia commented 4 months ago

It generates completion files(e.g. ~/.dart-cli-completion/fvm.zsh) under ~/.dart-cli-completion/ and it appends its configuration in the zsh configuration file(.zshrc etc)

Ah right, it uses this package. But it doesn't work on my machine for some reason. Thanks for checking!

it appends its configuration in the zsh configuration file(.zshrc etc)

I really don't like this behavior. I want my completion scripts to live in e.g. /opt/homebrew/share/zsh/site-functions/, and not modify (!) my dotfiles and ~/.config.

bartekpacia commented 4 months ago

So yeah, let's remove _fvm from this repo.

Did you write that completion script manually?

syohex commented 4 months ago

Did you write that completion script manually?

Yes

syohex commented 4 months ago

I've removed it at #1076