oh-my-zsh plugin naming

zsh-users / zsh-history-substring-search

🐠 ZSH port of Fish history search (up arrow)

2.52k stars 155 forks source link

oh-my-zsh plugin naming #101

Open jjangga0214 opened 5 years ago

jjangga0214 commented 5 years ago

README.md says to add oh-my-zsh plugin with name of history-substring-search. However, this is inconsistent with zsh-users' other plugins, such as zsh-completions, zsh-syntax-highlighting and zsh-autosuggestions, which are all prefixed by zsh and have same name with their repositories.

And actually, specifying its name as zsh-history-substring-search also works.

So, why not change it? Is it due to some historical reason?

sunaku commented 5 years ago

Yes, that is correct! :+1: The plugin name originally included a "zsh-" prefix in #87, but it was later changed to remove the "zsh-" prefix in #91 because the prefix was causing installation problems for a user (@beheist).

If you can confirm that it's no longer a problem, please submit a PR that restores the "zsh-" prefix. Thanks!