search

zsh-users / zsh-history-substring-search

🐠 ZSH port of Fish history search (up arrow)
2.61k stars 156 forks source link

Not highlighting in zsh 5.9 #131

Closed rightaway closed 11 months ago

rightaway commented 2 years ago

Words that have already been highlighted by zsh-syntax-highlighting aren't highlighted anymore by this plugin in zsh 5.9. It was working in 5.8. Any workaround?

webartifex commented 2 years ago

On my machine, I have the exact same issue with zsh 5.8.1 !

If someone tells me how I could be of helf (I am a Python dev), I will gladly look into this.

StaticESC commented 2 years ago

I have the same issue on zsh 5.9-1

danielshahaf commented 1 year ago

See #135 and compare my comments at https://github.com/zsh-users/zsh-syntax-highlighting/issues/872#issuecomment-1312034288.

rightaway commented 1 year ago

@danielshahaf Is it something you can fix in this plugin so we can upgrade to 5.9?

danielshahaf commented 1 year ago

@rightaway I neither use nor maintain this plugin. (My comment says "Member" because, being a z-sy-h maintainer, I am a member of https://github.com/zsh-users/; however, I don't have any special permissions on this repository.)

Fortunately, #135 which I linked to is a PR against this plugin. There's nothing stopping you from merging it locally — on the proviso that if it breaks anything, you get to keep both pieces.

Good luck.

rightaway commented 1 year ago

@sunaku is the maintainer but not sure if this package is still maintained because no activity in the last year and half. Anyone know of alternatives that can be used with the latest zsh?

rightaway commented 1 year ago

@guidovansteen @jirutka Could you take a look at this issue so that it's possible to upgrade to the latest zsh? Stuck on 5.8.

rightaway commented 1 year ago

@sunaku Could you take a look at this issue so that it's possible to upgrade to the latest zsh? Stuck on 5.8.

Koston-0xDEADBEEF commented 12 months ago

The commit above fixes the immediate issue, but I don't understand the code nearly well enough to say if it's an appropriate fix or just haphazardly masking a problem elsewhere.

rightaway commented 11 months ago

It can be the zstyle or region_highlight changes from https://zsh.sourceforge.io/releases.html that broke highlighting.

Koston-0xDEADBEEF commented 11 months ago

I've pushed a new version of the patch, which also explains what it does and why.

deponian commented 11 months ago

@Koston-0xDEADBEEF Thank you!

Koston-0xDEADBEEF commented 11 months ago

Patch is now merged, as @sunaku kindly trusted me with merge permission to this repository. Thank you!