search

zsiciarz / django-markitup

Markup handling (using Jay Salvat's MarkItUp! flexible universal markup editor) for Django
https://github.com/zsiciarz/django-markitup
BSD 3-Clause "New" or "Revised" License
47 stars 31 forks source link

Add python3.2 support #6

Closed TigorC closed 10 years ago

carljm commented 10 years ago

Usage of Python 3.2 is quite low, AFAIK. This PR is pretty simple, but I'm not sure I see a good reason for django-markitup to adopt support for 3.2.

carljm commented 10 years ago

Although the change looks simple, it involves using native strings (which are bytes in Python 2.x and unicode in Python 3) in a number of places where we really should be using text/unicode strings. This could cause issues with auto-coercion to bytes, and I don't want to risk that. So I'm sorry; thanks for the contribution, but I'm ok with not supporting Python 3.2.

carljm commented 10 years ago

(If I did want to add support for Python 3.2, I would do it by using from __future__ import unicode_literals in the modified files to avoid the above problem.)