Closed swerder closed 1 month ago
Sorry, GitHub seems to have issues and is not showing the current state of the branch on my end and somehow make some weird things. I am currently not even able to checkout the branch...
Ah darn, sorry @swerder I did not realise until now that your PRs are from a forked repo, since I have not access to your repo I will not be able to rebase this stuff properly and merge your PRs in a timely manner since I might have to wait for your changes every time I merge something into our dev
branch.
Would it be possible for you to give me access to your repo? Then I should be able to handle everything by myself and I won't need to bother you next week or so :)
@thegnuu as I'm not part of your group/collaborator I had to fork to do changes. I send you a colleborate invate to my repos/forks.
@swerder no worries, that's totally fine. Thanks a lot for the access! But since I have to merge a lot of stuff it will be easier if I can pull those changes into your repo and do everything at once, so you don't have to do anything and I will not have to wait for you, I am absolutely sure you have other things to do right now ;)
I will merge all your changes in the upcoming two to three weeks :)
@swerder and if you have plans to make some changes in the future I can tell the guys to add you to the repo as well...
@thegnuu I used the most of my spare time in the first half of the year for my changes here. currently I make a break. but what's still missing, and I plan to do is the "extension" of #429 to also allow "continue" work offline also with page refresh, and allow to push all to the server when have again internet. also there may be some conceptual problems for longer offline time/switching operations with the immer patches I want to verify/fix.
This implements / fixes: https://github.com/zskarte/zskarte-client/issues/259
It is based on changes from https://github.com/zskarte/zskarte-client/pull/400
The QR-Code deeplinks only work together with https://github.com/zskarte/zskarte-client/pull/405
The new print sidebar is shown by clicking on "Print" menu point in menu sidebar or if the user presses Ctrl+P / Meta+P or the Browser Print function is called from menu. In the last case the browser print view is still shown (cannot be bypassed). Pressing Esc closes now any sidebar.
The attribution was missed for OSM Tiles, I added them. Also updated the attribution on other layers to work and match the ones in geoAdmin Layers. The attribution was not shown on the page, I added the corresponding ol-component, and move it to "center bottom" of the view. Based on the logic the sidebar goes "over" the map and not change the size of it, it's not optically center if an sidebar is open. This sidebar behavior was also the reason I had to move it to center because it would not be visible otherwise.
I need to add
crossOrigin: 'anonymous',
to all tile layers/sources because otherwise the canvas was "tainted" and could not be exported anymore.I added an global css class
like-mat-form-field-outline
to be used with fieldset to have the same border style for radioGroup and checkboxes as for other input fields.The option emptyMap and the available paperFormat allow to use the print/pdf function also to create maps for drawing physically on it (up to A0), a feature our ZSO miss on all other online map/mapping tools...
Normal mode is to allow user to select the area to print(click on the map), and based on the other options the corresponding scale is calculated. It is also possible to select an specific scale in the dropdown.
While printing the map interactions are deactivated to prevent interrupting the print view settings. While printing there is also a progress bar, showing progress of loading needed tiles (0-80%) and do the other pdf generation work.(80-100%)
And "direct print" function as mentioned in issue is not implemented, as this have no added value than use the print on the directly opened pdf.
example pdf: Druck Test Operation_A5.pdf