zsmartsystems / com.zsmartsystems.zigbee

ZigBee Cluster Library Java framework supporting multiple dongles
Eclipse Public License 1.0
142 stars 88 forks source link

Improve group management response reporting #1296

Closed cdjackson closed 2 years ago

cdjackson commented 2 years ago

Note that this change is a breaking change to the API as it now returns a ZigBeeStatus rather than a boolean for the add/remove group member methods.

Signed-off-by: Chris Jackson chris@cd-jackson.com

cdjackson commented 2 years ago

@sorinpenteleiciuc please can you take another look at this. The issue is that the getStatus method only works on ZDO responses since ZCL responses don't consistently have a response status.

I've now updated the way this is handled.

cdjackson commented 2 years ago

@sorinpenteleiciuc is there any update to this please?

sorinpenteleiciuc commented 2 years ago

@sorinpenteleiciuc is there any update to this please?

It should be fine

cdjackson commented 2 years ago

Thanks for testing @sorinpenteleiciuc - I'll merge this now.