search

zsoh97 / pe

0 stars 0 forks source link

add and edit command error message should only be displayed upon entering a deck. #4

Open zsoh97 opened 4 years ago

zsoh97 commented 4 years ago

When no deck is selected, edit error message displays error message for editing a card in a deck.

steps to recreate: 1.type edit upon launching

image.png

nus-pe-bot commented 4 years ago

Team's Response

Hello, thank you for your report.

Please note that the syntax of your edit command is invalid.

Expected: An error telling the user they cannot edit a card in the play view, or that the command is unknown. Actual: An error telling me the edit command format is wrong. The app should prioritise telling the user that the command is unknown or the editing cannot be done in play view.

The reason why we did not have a message saying that the command is unknown is because we would like the user to know that they have entered a valid command word, but in the wrong format. If we were to tell the user it is unknown, it might confuse the user and the user might think that the command word doesnt exist at all.

Also, if the user entered a valid edit command, then our product will throw an error saying that the command cannot be done in play view. Because the user typed in the incorrect format, we first warned the user that the command they are trying to execute is in the wrong format. Then, if they have the correct format but wrong context, we will then tell them the error is wrong.

This is a result of the design of our product and we will take this suggestion into our design in future update

Rejected because it is a suggestion and not a bug due to our product design.

Also, downgraded to low as it only causes a minor inconvenience to the user and does not affect product operations/usage

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The report was that this functionality is a feature flaw as it was what I felt the feature should include. As explained by the team, the program first checks if the syntax is correct before it checks if the person is in the correct view. As explained in the title of my report, for user experience, the error message should first check if the user is in the correct view before checking if the syntax is accurate. The current implementation gives the user misinformation that the user could use the edit command in the library view when in fact it cannot, the user will only find that out after providing the required syntax and format. What I have suggested is to simply swap the order from a user's point of view.

The team's reasoning: "The reason why we did not have a message saying that the command is unknown is because we would like the user to know that they have entered a valid command word, but in the wrong format." is misleading. What is the point of knowing the correct format of the command if when I get it correct, I would still be unable to use it on the current view?

"If we were to tell the user it is unknown, it might confuse the user and the user might think that the command word doesnt exist at all." is based on their current flawed implementation of only displaying "unknown command" whenever the program does not recognise a command.

Lastly, the team themselves have stated that they would "take this suggestion into their design for future updates " indicating that they too would like the feature to function in my suggested way.

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: The report was that this functionality is a feature flaw as it was what I felt the feature should include. As explained by the team, the program first checks if the syntax is correct before it checks if the person is in the correct view. As explained in the title of my report, for user experience, the error message should first check if the user is in the correct view before checking if the syntax is accurate. The current implementation gives the user misinformation that the user could use the edit command in the library view when in fact it cannot, the user will only find that out after providing the required syntax and format. What I have suggested is to simply swap the order from a user's point of view. The functionality of the program itself is not affected by what is stated the report which is a prerequisite for a functionality bug.