Links to player profiles don't work

zsol / cupapp

A starcraft2 replay sharing site

www.cupapp.com

8 stars 0 forks source link

Links to player profiles don't work #12

Closed zsol closed 13 years ago

zsol commented 13 years ago

Except for replays from EU. This is only because the link is hard coded to start with eu.battle.net. Changing it manually to kr for korean replays work fine.

eshton commented 13 years ago

I was wondering maybe from the replay you could decide what server the player was playing on so you could generate the correct url.

The url got hardcoded because I wanted to check it out whether it is working or not and I didn't get back to make it right :)

zsol commented 13 years ago

Yup the replay parser is able to tell the region, we just have to check that value and translate it to the correct battle.net website if needed. I'll code this up soon

zsol commented 13 years ago

This is done, with the caveat that

I haven't been able to test Taiwanese and Chinese replays
The string returned by the parser does not necessarily correspond to the string used in the URL, for example for South East Asia, the replay returns sg, while the url contains sea. I expect this to be the case for regions with more than 2 character abbreviations in the url.