Matchup, team sizes and teams are not present on detail page

zsol / cupapp

A starcraft2 replay sharing site

www.cupapp.com

8 stars 0 forks source link

Matchup, team sizes and teams are not present on detail page #17

Closed eshton closed 13 years ago

eshton commented 13 years ago

On the replay details page some additional information is needed:

Matchup (PvT etc)
Team sizes (2v2 3v3 etc)
On the "players" box there is only a list of players but they are not grouped into teams

zsol commented 13 years ago

Anathien worked on grouping the teams and a bit of css magic, which is now uploaded. Team sizes reported by the library can be sometimes unreliable, especially with some wicked custom maps. As for the matchup, I think the icons are enough, but am open for discussion :)

zsol commented 13 years ago

check out the current layout on http://test.cupapp.com and close this if you're ok with it otherwise, suggestions are welcome

eshton commented 13 years ago

I love the new replay details page, it looks tremendous! But I would be a bit happier with a one pixel bigger font size :)

zsol commented 13 years ago

can you send anathien (gmail) a screenshot? It looks fine for us

eshton commented 13 years ago

well it might just be a personal preference but i hate when the texts are too small, harder to read and also doesn't make any big difference. test with 12px body font size please.

anathien commented 13 years ago

I have changed the font size to 12px for you to check, it's available under anathien.cupapp.com. Please note that I have only yet redesigned the replay details page, so don't check font size, padding, or actually anything outside of that view.

My personal opinion is that like this, the font would just be a tad too big for the normal screens (common resolutions). Especially the headers and all titles - although could make them smaller, but that would make them blend into the normal text.

Why I would like to see a screenshot of yours is the following: we have tested the page on Zsol's computer running Linux and the fonts have become extremely small there. I would like to know whether they show up on your screen as I have intended, or you are facing a similar issue. This would help me in fixing the layout.

eshton commented 13 years ago

Yeah I'm using Linux mostly but I can see the same difference on Windows as well. With the 12px it looks okay to me.

anathien commented 13 years ago

I've given it a try with a size-mix and I think I'd be fine with this. I left the body size to 12px, but decreased all headers to their previous sizes. You can see the change on test.cupapp.com. Please let me know what you think.

zsol commented 13 years ago

I like it

eshton commented 13 years ago

Thumbs up!

zsol commented 13 years ago

Closing this one, then