zsol / cupapp

A starcraft2 replay sharing site
www.cupapp.com
8 stars 0 forks source link

Player APM doesn't fit in display box #9

Closed zsol closed 13 years ago

zsol commented 13 years ago

When player's name is too long, the APM gets chopped and it doesn't display. See http://cupapp.dyndns.info/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme for an example

eshton commented 13 years ago

We have to investigate the maximum length of the player's name and set the size of that box so it will fit in all the time. I think the icon should be smaller as well.

zsol commented 13 years ago

The max length of an SC2 nickname is 12 characters currently. I'd say let's make it 200px wide, so the left panel would be 360px then. Agree? I'll upload even smaller icons soon

eshton commented 13 years ago

I believe is you just make the icon smaller then it will resolve this problem. Also, the example disappeared :D

zsol commented 13 years ago

The example is here: http://test.cupapp.com/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme

I have set the players panel to 200px and made the icons smaller. I still think it's possible for player names to be too long (i.e. "MMMMMMMMMMMM" would probably not fit), but I have also noticed that giving a really long description for a replay also screws up the layout so we might have to come up with a more dynamic one. Example: http://test.cupapp.com/en/replay/view/12/Nemtudni-Metalopolis-Flint-Zsol-sHadowLigHt-Stylosa

eshton commented 13 years ago

Put the description field in a paragraph tag and add the next styles: width: 260px; word-wrap: break-word;

zsol commented 13 years ago

this is now fixed in the latest commit