search

zsol / py.wtf

Autogenerated reference docs for PyPI packages
https://py.wtf
MIT License
10 stars 3 forks source link

@welcome-ui/link vs react-router-dom #32

Closed abesto closed 2 years ago

abesto commented 2 years ago

We use client-side routing for ... reasons. That means react-router-dom. The Link component of react-router-dom renders an <a> tag, and you don't get a say in this matter. However, we also use WelcomeUI; the WUI Link component (that we kinda need for styling / themeing) also renders an <a> tag, and you don't get a choice in THAT matter either.

Unfortunately an <a> tag inside another <a> tag is not valid, and generates a warning. It works, but it'd be good to not be clowny.

anathien commented 2 years ago

Closing this PR in favor of another approach, going back to vanilla Styled Components.

anathien commented 2 years ago

Woops, closed the wrong thing yesterday (issue vs PR). That said, this was solved by the alternate approach, https://github.com/zsol/py.wtf/pull/57 .