search

zsoldosp / django-currentuser

Conveniently store reference to request user on thread/db level.
BSD 3-Clause "New" or "Revised" License
139 stars 40 forks source link

support Django 2.0 fixes #12 #11

Closed zsoldosp closed 6 years ago

zsoldosp commented 6 years ago

see #9 , #12

kairichard commented 6 years ago

@zsoldosp the travis.yml also needs to learn the new environment in order to publicly reflect what versions are supported.

zsoldosp commented 6 years ago

@kairichard could you run tox2travis.py and commit? I don't actually have a working py env (and add it as a check to the Makefile so it fails if the generated output is different)

belugame commented 6 years ago

@zsoldosp running tox2travis.py only reorders the envs from 3.4, 3.5, 3.6 to 3.4, 3.6, 3.5

zsoldosp commented 6 years ago

@belugame did you check before or after 4634fd0?

zsoldosp commented 6 years ago

@kairichard @belugame right now I don't have the time & the upgrade to 2.0 needs actual logic change (AttributeError: 'CurrentUserField' object has no attribute 'rel'), and for the coming weeks I don't have the free time to deal with that. Could you please either finish it based on this branch, or open an issue and reference this pull? Thanks

kairichard commented 6 years ago

@zsoldosp Thanks for taking this off the ground we will try to finish based on the work you already put into it.

belugame commented 6 years ago

@zsoldosp It was after/with 4634fd0

zsoldosp commented 6 years ago

@belugame then it makes sense it just reordered it (windows vs. mac, python version diff I assume), as I've updated the .travis.yml file already :)

zsoldosp commented 6 years ago

@belugame thanks!

@kairichard the autorelease is still in place, i.e.: if I merge it, it'll be published to pypi, right?

kairichard commented 6 years ago

@zsoldosp yes it's still humming away