search

zsoldosp / django-currentuser

Conveniently store reference to request user on thread/db level.
BSD 3-Clause "New" or "Revised" License
141 stars 40 forks source link

Support for Django 2.2 #27

Closed fabio-filho closed 5 years ago

fabio-filho commented 5 years ago

Talking about the support for Django 2.2, is there anything related on the roadmapping?

lino commented 5 years ago

Is there even anything that needs to be done besides changing dependencies?

djkgamc commented 5 years ago

Seems to work if you just ignore the < 2.2 requirement. Might have been a mistake

zsoldosp commented 5 years ago

linking PR #28 to this issue

Eorhim commented 5 years ago

This is addressed in pull request #29. It was slightly more involved than just updating the referenced versions, but no big deal.

zsoldosp commented 5 years ago

As per https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django

2.2 Django only supports python versions 3.5 and upwards. Which python version are you using? #29 seems to have set it up correctly to me

(copying comment from duplicate issue #30 and PR #31 is also related)

zsoldosp commented 5 years ago

I think the root cause of the problem is that the first line of the install_requires is not bound by python version, thus always gets applied (from #31 comment)

serafdev commented 5 years ago

Pull request #33 should fix this issue

serafdev commented 5 years ago

I just tested, it's fixed in 0.4.2, this can be closed