zsoldosp / django-currentuser

Conveniently store reference to request user on thread/db level.
BSD 3-Clause "New" or "Revised" License
141 stars 40 forks source link

Added django 2.2 support #28

Closed lino closed 5 years ago

lino commented 5 years ago

tox tests are passing

zsoldosp commented 5 years ago

Hi @lino, thanks for the PR, it looks good to me! :+1:

When new releases are made, the following changes also should happen

However, I recall that for releases there was a problem with 3.7 python recently, cc'ing @kairichard and @Eorhim for input on that

Eorhim commented 5 years ago

@lino, @zsoldosp

The problem with Python 3.7 was solved in fe951cf6807beb9671734a2a13ffb07391fa7a81 by cutting out some outdated build system and using the Travis functionality directly.

Unfortunately tox2travis.py wasn't updated. So if you want to use that script to generate the .travis.yml configuration, you will loose the packaging ability.

Eorhim commented 5 years ago

@lino: I close this pull request, because I extended your work in pull request #29.

Thank you for pushing the project forward with your work.