Wrong pinning of versions

zsoldosp / django-currentuser

Conveniently store reference to request user on thread/db level.

BSD 3-Clause "New" or "Revised" License

141 stars 40 forks source link

Wrong pinning of versions #30

Closed mattLLVW closed 5 years ago

mattLLVW commented 5 years ago

It seems there's an issue with the pinning of version.

It's currently impossible to use django-currentuser 0.4.1 with Django 2.2.1.

ERROR: django-currentuser 0.4.1 has requirement Django<2.0,>=1.11.17, but you'll have django 2.1.8 which is incompatible.
ERROR: django-currentuser 0.4.1 has requirement Django<2.3,>=2.2.1; python_version > "3.4", but you'll have django 2.1.8 which is incompatible.

Step to reproduce:

pip install django
pip install django-currentuser

n-rodriguez commented 5 years ago

Neither with Django 2.2.2 :

django-currentuser 0.4.1 has requirement Django<2.0,>=1.11.17, but you'll have django 2.2.2 which is incompatible.
django-currentuser 0.4.1 has requirement Django<2.2,>=2.1.8; python_version > "3.4", but you'll have django 2.2.2 which is incompatible.

belugame commented 5 years ago

One of you would like to make a pull request? I'd be happy to merge it.

n-rodriguez commented 5 years ago

One of you would like to make a pull request? I'd be happy to merge it.

Hi! Sorry I'm not a Python developer :/

zsoldosp commented 5 years ago

As per https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django

2.2 Django only supports python versions 3.5 and upwards. Which python version are you using?

Also, I think this is a duplicate of #28 thus closing it here (#31 is also related)

n-rodriguez commented 5 years ago

Which python version are you using?

Python 3.7