Django v. 3.0 compatibility

zsoldosp / django-currentuser

Conveniently store reference to request user on thread/db level.

BSD 3-Clause "New" or "Revised" License

157 stars 40 forks source link

Django v. 3.0 compatibility #38

Closed snake-soft closed 4 years ago

snake-soft commented 4 years ago

I tested it with version 0.4.2 and it seems to work fine with django3.0 after editing parameters in setup.py.

mattLLVW commented 4 years ago

@belugame any news about this?

belugame commented 4 years ago

@mattLLVW @jimothyGator sorry for the long delay can you increase the version number for a new release, please? may be not the only spot where it is specified:

https://github.com/PaesslerAG/django-currentuser/blob/master/django_currentuser/__init__.py

jimothyGator commented 4 years ago

Good questions. The main reason was to include the update to tox.ini.

Note that my change will work on Django 3.0.2 as well. It just won't work with Django 3.1 (which doesn't exist yet). Will django-currentuser work with with Django 3.1 without additional changes? Your guess is as good as mine, which is why I went with the conservative approach.

Also note that your PR will also accept Django 3.0.0, so if there's a security issue in that version, neither PR is better than the other in that regard.

belugame commented 4 years ago

@jimothyGator Thank you for setting things straight. @mattLLVW:

We aim to support the latest stable release and want test coverage of all version combinations, which your MR did not give.
Leaving it open to future releases or untested combinations could break people's projects while the merged changes does not stop anyone from using a 3.0 bugfix version.

belugame commented 4 years ago

Feel free to tag one of the main contributors if you think you ticked all boxes in terms of QA, and hopefully next time we have more time at hands to react in a fast manner. Appreciate your contributions :)

belugame commented 4 years ago

@jimothyGator @snake-soft @mattLLVW 0.4.3 is now on pypi

https://pypi.org/project/django-currentuser/0.4.3/