search

zsoltk / compose-router

[DEPRECATED] Routing functionality for Jetpack Compose with back stack
Apache License 2.0
635 stars 36 forks source link

Updated for Jetpack Compose dev15 and Android Studio 4.2 Canary 5 #35

Closed madhavajay closed 4 years ago

madhavajay commented 4 years ago

I got everything working, however I can't figure out the correct way to handle the three unchecked casts properly. I left the @Suppress("UNCHECKED_CAST") commented near each one.

I guess this is something to do with Covariance / Contravariance etc, but I dont know enough about how to solve it. Seems theres a List and a Map with BackStack<*>. Would one solution be to have some kind of known Routing interface or class which is subclassed or implemented so that the type and its sub/super are known?

I would be interested in knowing how this should be fixed so that I can understand this whole <*> thing in Kotlin.

madhavajay commented 4 years ago

Okay, I have made all the changes and squashed into a single commit. I will open a separate PR for the CI stuff after this is merged and I can rebase. Let me know if theres anything else you need me to change. 😊

ShikaSD commented 4 years ago

@madhavajay amazing, thanks 👐 . I still see a new yaml file in the diff, can you recheck if you have removed everything? Otherwise, LGTM. cc: @zsoltk

madhavajay commented 4 years ago

@ShikaSD Sorry, I missed that when I squashed the commits. It's gone now, so I think we're ready for merge. Thanks for the patience.

zsoltk commented 4 years ago

@madhavajay @ShikaSD thank you both!