zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+

Other

1.99k stars 60 forks source link

Don't insert a conjunction if the substition array contains only one item #117

Closed LucianBuzzo closed 6 years ago

LucianBuzzo commented 6 years ago

Fixes #116

codecov-io commented 6 years ago

Codecov Report

Merging #117 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #117   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         149    150    +1     
=====================================
+ Hits          149    150    +1

Impacted Files	Coverage Δ
...c/inlineArrayTransformer/inlineArrayTransformer.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 147a84a...0b15db9. Read the comment docs.

fatfisz commented 6 years ago

Hi, good catch and thanks for the fix!

I'd be very much interested in merging this, but there is a thing that needs to be fixed beforehand: after upgrading ava some behavior around the CWD has changed and as a result all readFromFixture calls need to receive __dirname as the first parameter. Could you fix that up?

Also, could you also add yourself to the list of contributors in package.json?

LucianBuzzo commented 6 years ago

@fatfisz Sure thing, I'll update this now

LucianBuzzo commented 6 years ago

@fatfisz I've updated the PR with the changes you mentioned and rebased against master, we should be good to go :+1:

fatfisz commented 6 years ago

Thanks for the contribution! I'm planning on releasing this sometime during the next 24h - I'll give you a heads up.

fatfisz commented 6 years ago

This fix was released in 1.5.0!