search

zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+
Other
1.99k stars 61 forks source link

migrate to jest from ava #138

Closed zspecza closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #138 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #138   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines         160    102   -58     
  Branches        0     29   +29     
=====================================
- Hits          160    102   -58
Impacted Files Coverage Δ
src/safeHtml/safeHtml.js 100% <0%> (ø) :arrow_up:
src/oneLine/oneLine.js 100% <0%> (ø) :arrow_up:
src/TemplateTag/TemplateTag.js 100% <0%> (ø) :arrow_up:
src/oneLineTrim/oneLineTrim.js 100% <0%> (ø) :arrow_up:
src/html/html.js 100% <0%> (ø) :arrow_up:
src/commaListsAnd/commaListsAnd.js 100% <0%> (ø) :arrow_up:
src/stripIndent/stripIndent.js 100% <0%> (ø) :arrow_up:
src/stripIndents/stripIndents.js 100% <0%> (ø) :arrow_up:
...sTransformer/removeNonPrintingValuesTransformer.js 100% <0%> (ø) :arrow_up:
src/oneLineCommaListsOr/oneLineCommaListsOr.js 100% <0%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5f9e08...e52a041. Read the comment docs.

zspecza commented 6 years ago

The build is failing on Node.js 5 because Jest test files have to be transpiled - I for some reason cannot get it to actually detect that we're using Babel. I will take a look at this later as it seems I have run out of time for now.

zspecza commented 6 years ago

Turned out the issue was just with JSDom. Had to switch to Node.js test runner. I'm not too happy about the amount of config this took, but my prediction that CI build speeds would improve was right on the money - CI is now happening 4-5 times faster than it was before this PR. The next sprint will likely make CI faster as its simply reconfiguring CI especially for that purpose. As for configs, the TypeScript sprint should improve that marginally.

I took the liberty of adjusting some of the linting config in this release, as I was still being shouted at by my IDE for a few things. One drawback is that we've had to drop the use strict directive in config files, but since they're just config files, I'm happy to make that sacrifice.

fatfisz commented 6 years ago

About --ignore-pattern '!.*rc.js' - I had the same problem today too and it turns out that in Windows cmd arguments like .*rc.js are not expanded, but in bash, etc. they are. I solved it by wrapping .*rc.js, like so: '.*rc.js'.

zspecza commented 6 years ago

I’m fine with that, when it comes to Windows my stance is to not bother fighting with build tools built for bash. Anyone with issues on windows can simply run docker, vagrant, git bash, conemu or whatever to get ahead of bash shortcomings on windows.

Sent from my iPhone

On 14 Jan 2018, at 02:31, Rafał Ruciński notifications@github.com wrote:

About --ignore-pattern '!.rc.js' - I had the same problem today too and it turns out that in Windows cmd arguments like .rc.js are not expanded, but in bash, etc. they are. I solved it by wrapping .rc.js, like so: '.rc.js'.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.