search

zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+
Other
1.99k stars 61 forks source link

move babel-runtime to devDependencies #142

Closed coolreader18 closed 6 years ago

coolreader18 commented 6 years ago

This would resolve #108 if merged.

This would break very little, as it would mostly only change for people who use the package in a node environment. If you look at this yarn blog post (I just remember reading that a few days ago), the devDependencies are only installed if

  1. the package is at the top of the dependency tree
  2. its dependencies are not installed in production mode

Given that babel-runtime is not imported or requireed anywhere in the src or lib folders (on jsdelivr for the latter), it wouldn't be necessary to include it in the regular dependencies, and have a fairly large library taking up space in people's dependencies when all they want to do is install a cool template tag module. :grin:

codecov[bot] commented 6 years ago

Codecov Report

Merging #142 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #142   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines         102    102           
  Branches       29     29           
=====================================
  Hits          102    102

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 956daa6...1abf8ba. Read the comment docs.

coolreader18 commented 6 years ago

Ok nevermind, I'm just blind, it is in the built directories.