zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+

Other

2k stars 61 forks source link

Fix `oneLineCommaLists` result comment in readme docs #199

Closed ahmadatallah closed 4 years ago

ahmadatallah commented 4 years ago

I figured out when reading the readme file that oneLineCommaLists tag function has a wrong result comment, so I fixed it!

codecov[bot] commented 4 years ago

Codecov Report

Merging #199 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          121       121           
  Branches        31        31           
=========================================
  Hits           121       121

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37bb5e1...08edccd. Read the comment docs.

ahmadatallah commented 4 years ago

Please leave just readme.md changes and we'll be ok

I didn't change anything there in package-lock.json. it's auto-generated when I run npm install as described in the contribution section. may be it's because of the npm version I used at that moment!

ahmadatallah commented 4 years ago

@fatfisz can you please define the npm version used in contribution guideline to avoid such cases? I believe that optional property is not something that will affect the project. but just in case you don't need changes like that in the project!

fatfisz commented 4 years ago

Frankly, I think it would be better to just switch to yarn for this project; I haven't used npm for a long time and yesterday it caught me by surprise a few times with unintuitive behavior when I was updating packages.

Anyway, thanks for the contribution, I'm merging!