search

zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+
Other
1.99k stars 60 forks source link

ECMAScript support #212

Open Siilwyn opened 3 years ago

Siilwyn commented 3 years ago

Each commit has a body with some more more information about the changes. Commit (a68b0f3) drops support for Node.js 10 making it a breaking change which might be possible to include in v2? It does decrease the package size since no CommonJS build output is packed anymore. Feel free to rebase or cherry pick some of the changes!

codecov[bot] commented 3 years ago

Codecov Report

Merging #212 (c0ce012) into master (d3f7042) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #212   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          121       121           
  Branches        31        31           
=========================================
  Hits           121       121
Impacted Files Coverage Δ
src/TemplateTag/TemplateTag.js 100.00% <ø> (ø)
src/commaLists/commaLists.js 100.00% <ø> (ø)
src/commaListsAnd/commaListsAnd.js 100.00% <ø> (ø)
src/commaListsOr/commaListsOr.js 100.00% <ø> (ø)
src/createTag/createTag.js 100.00% <ø> (ø)
src/html/html.js 100.00% <ø> (ø)
src/id/id.js 100.00% <ø> (ø)
...c/inlineArrayTransformer/inlineArrayTransformer.js 100.00% <ø> (ø)
src/inlineLists/inlineLists.js 100.00% <ø> (ø)
src/oneLine/oneLine.js 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3f7042...c0ce012. Read the comment docs.

Siilwyn commented 3 years ago

Today I noticed that directory imports (e.g. import x from './some-dir') do not work. A full path including extension is needed to work in vanilla Node.js.

Siilwyn commented 3 years ago

Ready for review @fatfisz & @zspecza.

Siilwyn commented 3 years ago

@fatfisz friendly ping! I've been running into problems with npm 7 and using git tarballs as a workaround for using this patch instead of the published npm package. Let me know if I can help with anything.

Siilwyn commented 2 years ago

👋 @fatfisz hope you can find some time to review this PR soonish 🤞

damianobarbati commented 2 years ago

@Siilwyn repo is clearly dead. Should we simply fork the repo and re-publish on npm, with all of this merged?

Siilwyn commented 2 years ago

Hey thanks for the idea @damianobarbati, I did email a bit with the author and he did have intentions to merge this but was very busy. I'll look into forking soonish.

Siilwyn commented 1 year ago

Okay it's happening! I've created https://github.com/Siilwyn/common-tagged and intend to publish it coming week. But just before that I'd like to see if there are other alternatives perhaps, @damianobarbati do you still use this package?