search

zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+
Other
1.99k stars 60 forks source link

no longer require npm3 #44

Closed zspecza closed 8 years ago

zspecza commented 8 years ago

resolves #43

ntwb commented 8 years ago

The README also needs an update: https://github.com/declandewet/common-tags/blob/master/readme.md#requirements

ntwb commented 8 years ago

If I was to be pedantic: (this comes with Node.js) should be (this comes with Node.js > 5.x)

i.e. NodeJS 4.x ships with NPM 2.x, NodeJS 5.x & 6.x ship with NPM 3.x

zspecza commented 8 years ago

The intent in that sentence means that npm comes with Node - the version is just a specific technicality.

codecov-io commented 8 years ago

Current coverage is 100%

Merging #44 into master will not change coverage

@@           master   #44   diff @@
===================================
  Files           8     8          
  Lines          18    18          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           18    18          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last updated by e0a003e...8c4e84f

ntwb commented 8 years ago

Thanks for this @declandewet 👍