Added transformer to remove non-printing values.

zspecza / common-tags

🔖 Useful template literal tags for dealing with strings in ES2015+

Other

2k stars 61 forks source link

Added transformer to remove non-printing values. #54

Closed shannonmoeller closed 8 years ago

shannonmoeller commented 8 years ago

Resolves #29.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #54 into master will not change coverage

@@           master   #54   diff @@
===================================
  Files          22    23     +1   
  Lines         137   145     +8   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits          137   145     +8   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update b8e203e...93b892d

shannonmoeller commented 8 years ago

Looks like the travis tests actually passed, but the Node 4 process terminated early when running an unrelated and untouched test.

zspecza commented 8 years ago

Thanks for getting around to this @shannonmoeller - I've had a lot on my plate recently. Yeah, sometimes the tests get a little messed up, but rarely on Travis - mostly appveyor because it's so slow. Just want to trigger a rebuild to be exactly sure before merge... :)

zspecza commented 8 years ago

Seems that this error is due to an uncaught exception. Everything seems fine on Node 5 and 6, so I'm going to merge this in for the time being but will have to investigate this error a little more before publishing the next release, as I'm not convinced this is travis-specific

shannonmoeller commented 8 years ago

Ok. I'll try and take a look tonight, too.