search

zspitz / ExpressionTreeToString

String representations of expression trees + library of expression tree objects
MIT License
151 stars 12 forks source link

Textual tree renderer: Consider describing Type property as generic parameter of node #58

Closed zspitz closed 3 years ago

zspitz commented 4 years ago

For example, a MemberExpression node whose Type is string, should appear like this: MemberExpression<string> (or MemberExpression(Of String) for VB).

zspitz commented 4 years ago
Language Representation
None Member (String)
C# Member<string>
Visual Basic Member(Of String)

These are node types, not CLR types, so there's no danger of thinking them generic.

zspitz commented 4 years ago

A better choice might be to remove the space between Member and (string).

zspitz commented 3 years ago

We're not going to do this; it obscures the meaning of the NodeType value.