search

zsszatmari / MagicKeys

This is a preference pane for Mac OS X 10.7+ that enables hardware media keys (prev, play, next) to be routed to 3rd-party sandboxed applications in a nice way, without unwanted side effects. This has been specifically created with G-Ear, a native Google Music player for Mac in mind, but any suggestion or patch is welcome!
http://www.treasurebox.hu/magickeys
109 stars 15 forks source link

Code updates #8

Open smarek opened 9 years ago

smarek commented 9 years ago

Fixed universal developer ID, GC converted to ARC, unchecked signed-unsigned casts explicitly stated, fixed initial position of preferences XIB

Overall just some small changes and warnings fixed, when opening project in XCode (my env XCode 6.3.2, Yosemite 10.10.3)

Summary

zsszatmari commented 9 years ago

Thanks for the PR! I'd be happy to merge it in, but there is one small thing: the project unfortunately must remain GC-enabled in the repository. That's because Lion is supported, and Lion's System Preferences does not work non-GC prefpanes (as explained in the readme). Code is written in such fashion that it should behave correctly when compiled with either GC or ARC. Could you please revert it back to GC?