search

zsviczian / obsidian-excalidraw-plugin

A plugin to edit and view Excalidraw drawings in Obsidian
4.11k stars 226 forks source link

BUG: color selector apply the wrong color in the excalidraw darkmode #1049

Open littlewhite233 opened 1 year ago

littlewhite233 commented 1 year ago

Your environment SYSTEM INFO: Obsidian version: v1.1.16 Installer version: v1.1.9 Operating system: Windows 10 Home 10.0.18363 Login status: not logged in Insider build toggle: off Live preview: on Legacy editor: off Base theme: dark Community theme: Blue Topaz v20230218 Snippets enabled: 0 Restricted mode: off Plugins installed: 51 Plugins enabled: 33 1: Kanban v1.5.2 2: Excalidraw v1.8.18 3: Editor Syntax Highlight v0.1.3 4: Annotator v0.2.10 5: Spaced Repetition v1.10.0 6: Obsidian Memos v1.9.7 7: Media Extended v2.11.1 8: Longform v2.0.3 9: Media Extended BiliBili Plugin v0.3.1 10: QuickAdd v0.11.6 11: ABC Music Notation v1.2.0 12: Cmenu Plus+ v2.0 13: Reminder v1.1.15 14: Clear Unused Images v1.1.0 15: Advanced Tables v0.18.1 16: Hover Editor v0.11.9 17: Remember cursor position v1.0.7 18: Copy Block Link v1.0.4 19: Ozan's Image in Editor Plugin v2.2.2 20: Obsidian42 - BRAT v0.6.36 21: Bartender v0.5.7 22: Better Command Palette v0.15.0 23: floating toc v2.3.0 24: Style Settings v1.0.3 25: Table of Contents v0.1.4 26: Tag Wrangler v0.5.6 27: Templater v1.16.0 28: Pane Relief v0.4.1 29: Show Current File Path v0.5.2 30: Commander v0.4.9 31: Various Complements v8.0.0 32: Obsidian Charts v3.7.1 33: PodNotes v2.10.7

Describe the bug color selector apply the wrong color to any kind of tools. It looks like the color shows in the RGB palette will rotate 90 degrees and apply to the tools rect text draw etc...

To Reproduce

abc the left-hand side color is not same as the right-hand side color which i choose from color palette. And It apply the color not from the color selector

Expected behavior

The final apply color should be the color i selected from the palette.

zsviczian commented 1 year ago

very strange. I am unable to reproduce the error.

Does the color picker behave as expected for example in the appearance setting/Accent color in Obisidian settings?

image

littlewhite233 commented 1 year ago

The color picker in obsidian setting behaves as expected.

abcd

littlewhite233 commented 1 year ago

Hello. I just randomly navigate all my excalidraw file. And I find out that problem doesn't exist in the light mode. The error only reproduce in the dark mode. Just click the dark mode switch button in the excalidraw interface. Not the obsidian's DarkMode settings.

abcd

Servinjesus1 commented 1 year ago

Can confirm the issue in Obsidian v1.1.16, Excalidraw 1.8.26, freshly installed on sandbox vault. Reproduce by:

  1. Apply color to shape/text in new Excalidraw Drawing
  2. Change Excalidraw to Dark Mode
  3. Colors will mute by a bump up in lightness of 28% - 38% and possibly a slight hue shift.

Seems like a dark mode filter being applied to everything, not just the UI elements.