search

zsviczian / obsidian-excalidraw-plugin

A plugin to edit and view Excalidraw drawings in Obsidian
3.89k stars 211 forks source link

Closing the help panel leads to empty window/tab #1291

Open mistalazymoe opened 1 year ago

mistalazymoe commented 1 year ago

SYSTEM INFO: Obsidian version: v1.3.7 Installer version: v1.3.5 Operating system: Windows 10 Home 10.0.22621 Login status: not logged in Insider build toggle: off Live preview: on Legacy editor: off Base theme: dark Community theme: Things v2.1.11 Snippets enabled: 1 Restricted mode: off Plugins installed: 39 Plugins enabled: 27 1: Typewriter Scroll v0.2.2 2: Advanced Slides v1.20.0 3: Advanced URI v1.37.0 4: Better footnote v1.0.1 5: Better Word Count v0.10.0 6: Calendar v1.5.10 7: Tab Switcher v1.3.0 8: Dataview v0.5.56 9: Fullscreen mode plugin v0.1.2 10: Hider v1.2.5 11: Hotkeys++ v0.2.7 12: Hover Editor v0.11.13 13: Kanban v1.5.3 14: Kindle Highlights v1.9.2 15: Maximise Active Pane v0.0.3 16: Paste URL into selection v1.7.0 17: Recent Files v1.3.7 18: Templater v1.16.0 19: Smart Random Note v0.2.1 20: Spaced Repetition v1.10.1 21: Tag Wrangler v0.5.11 22: Diagrams v1.5.0 23: PodNotes v2.10.8 24: Media Extended v2.11.1 25: Advanced Tables v0.19.1 26: Periodic Notes v0.0.17 27: Excalidraw v1.9.17

Describe the bug With fullscreen activated (Fullscreen mode plugin v0.1.2), closing the help panel in Excalidraw leads to an empty window.

To Reproduce Steps to reproduce the behavior:

  1. Open Excalidraw note.
  2. Activate full screen via plugin shortcode
  3. Click on (i) bottom right
  4. Close panel, either clicking the (x) top right or outside of the help panel
  5. See error: Empty window. When exiting full screen mode the window is still empty. I have to close the tab and re-open the note to access content and tools again.

Expected behavior Help panel closes. Drawing panel stays in full-screen mode with content visible/editable and tools accessible.

Screenshots Open Tab Tab in fullscreen Help Panel open Help panel closed - Window empty Full screen mode exited - Tab still empty

Thanks for all the great work. And please keep it up. Also very intrigued by your Book on a Page Course. Will probably get back to that in a few months :-)

zsviczian commented 1 year ago

I am not able to reproduce this error. Does this happen for you every time?