search

zsviczian / obsidian-excalidraw-plugin

A plugin to edit and view Excalidraw drawings in Obsidian
4.23k stars 232 forks source link

BUG: Embedded Drawings Improperly Rendering in Light Mode #1363

Open tjg23 opened 1 year ago

tjg23 commented 1 year ago

Your environment

SYSTEM INFO: Operating system: ios 17.0.2 (Apple iPad) Obsidian version: 1.4.8 (107) API version: v1.3.7 Login status: not logged in Live preview: on Legacy editor: off Base theme: dark Community theme: obsidian-default-theme Snippets enabled: 1 Restricted mode: off Plugins installed: 44 Plugins enabled: 31 1: Advanced Tables v0.19.1 2: Calendar v1.5.10 3: Admonition v10.1.1 4: Mind Map v1.1.0 5: Tasks v4.9.0 6: Highlightr v1.2.2 7: Style Settings v1.0.7 8: Day Planner v0.10.1 9: Super Simple Time Tracker v0.1.8 10: Fleeting Notes Sync v0.6.2 11: Periodic Notes v0.0.17 12: Banners v1.3.3 13: Timeline v1.1.0 14: Outliner v4.8.0 15: Underline v1.2.1 16: Folder Note v0.7.3 17: Hotkey Helper v0.3.18 18: List Callouts v1.1.4 19: Latex Suite v1.8.4 20: Multi-Column Markdown v0.8.3 21: Settings Search v1.3.10 22: Breadcrumbs v3.6.4 23: Kanban v1.5.3 24: QuickAdd v1.4.0 25: Natural Language Dates v0.6.1 26: Projects v1.16.5 27: Frontmatter Links v1.2.7 28: Time Ruler v1.5.0 29: Dataview v0.5.61 30: Excalidraw v1.9.23 31: Iconize v2.4.2

Describe the bug Drawings embedded in markdown documents are always rendered in light mode, regardless of the state of the drawing and Obsidian or Excalidraw plugin settings.

To Reproduce Steps to reproduce the behavior:

  1. Create a markdown document in dark mode
  2. Embed or create and embed a drawing with the command palette
  3. Open the drawing and set it to dark mode if needed
  4. See error

Expected behavior The drawing should be shown with a dark background and the elements should be white

Screenshots image image image image

Additional context All plugin settings are set for drawings and embeds to match Obsidian theme

zsviczian commented 1 year ago

You seem to have the right settings. When you change settings you need to close and reopen the markdown document for the image to refresh. Additional, at an individual drawing level you can override these settings... feels unlikely, but please check your drawing in markdown view mode to see if you have the excalidraw-export-dark: false following frontmatter switch. If yes, delete it from the file.

stianthaulow commented 11 months ago

@tjg23 have you tried purging the cache? image

tjg23 commented 11 months ago

@stianthaulow I hadn’t tried that, but when I just opened Obsidian and looked at a note with an embedded drawing to test this, I saw that the issue was resolved. I’m still not sure of the cause, but yesterday I was troubleshooting an unrelated problem during which I disabled/reset all plugins and snippets and cleared my Style Settings, so I’m guessing there was a conflict somewhere. I might investigate further at a later date and try to recreate it, I’m not sure