zsviczian / obsidian-excalidraw-plugin

A plugin to edit and view Excalidraw drawings in Obsidian
3.68k stars 202 forks source link

FR: Implement Embedded PDF cropping to follow “Adapt to theme” option #1793

Open m1tyya opened 1 month ago

m1tyya commented 1 month ago

Your environment SYSTEM INFO: Obsidian version: v1.5.8 Installer version: v1.5.8 Operating system: Windows 10 Pro 10.0.25941 Login status: not logged in Insider build toggle: off Live preview: off Base theme: adapt to system Community theme: Border v1.7.8 Snippets enabled: 5 Restricted mode: off Plugins installed: 32 Plugins enabled: 24 1: Excalidraw v2.2.2 2: Calendar v1.5.10 3: Dataview v0.5.66 4: DB Folder v3.5.1 5: Templater v2.3.1 6: Tracker v1.14.0 7: Style Settings v1.0.8 8: QuickAdd v1.8.1 9: BRAT v1.0.1 10: Minimal Theme Settings v7.5.0 11: Hider v1.3.1 12: Auto Link Title v1.5.4 13: Rich Links v1.2.0 14: Reveal Active File Button v2.0.3 15: Banners v1.3.3 16: Sheets Extended v1.2.10 17: Iconize v2.12.0 18: Supercharged Links v0.11.1 19: Linter v1.24.0 20: Folder notes v1.7.22 21: Quick Switcher++ v4.0.0 22: Auto Card Link v1.2.3 23: Periodic Notes v0.0.17 24: LanguageTool Integration v0.3.7

Describe the bug When embedding a PDF with white background to a canvas with dark theme and then crop the page, the result has inverted colors and may hide black text from the PDF.

To Reproduce Steps to reproduce the behavior:

  1. Insert PDF with white background as embeddable. Obsidian_cv08XEK2yH
  2. (Optional) In case the document has inverted colors, toggle “Adapt to theme” option. Here it looks like a minor bug because with the option toggled OFF the PDF changes colors (image 1), while with the option ON the colors aren't inverted. On the other hand, in the PDF preview mode with the option OFF, the colors aren't changed as expected (image 2). Obsidian_Z6vHZXaEIE Obsidian_QZuunOaUML
  3. Double-click on PDF and choose “Crop and mask selected page”. At this stage you can see that the cropped image has already inverted colors (image 1). When I start adjusting the frame, something weird happens and the text is no longer visible (image 2). I've tried to change the cropped canvas background color (image 3), and toggling the theme change on the original PDF (image 4), but nothing has changed. Obsidian_JgD8jWVojI Obsidian_Yz3DxSAjy6 Obsidian_soaJAuyd37 Obsidian_ljqt8xklNI

Expected behavior The cropped image should inherit “adapt to theme” option from the original PDF document.

Additional context Just started using Excalidraw plugin, it's a game-changer for visualizing ideas. Really enjoying it so far, I'm happy to share my feedback with you.