Open KrazyManJ opened 2 months ago
Note: I've tried it with empty vault, and the same result happened. As well as trying to embed 3 areas to separate note, the same export time result.
I am able to reproduce.
Thank you @zsviczian for your response.
One note to mention, some kind of memory leak happens afterwards, Obsidian went skyrocket from 1GB of RAM usage to 5GB when exporting note with 6 different area sections inside. Sometimes export will just close and whole Obsidian freezes.
this issue opened a can of worms. There are many things wrong with the preview rendering, Export to PDF is just one of the many issues. Unfortunately, this is probably the most flaky of all my code in the plugin. There are many special cases to look out for, and Obsidian does not natively support the type of rendering Excalidraw does ![[drawing]]
. Obsidian's approach is built around code blocks, but code blocks come with lots of limitations... long story short I added some additional patching to the existing code, which drastically improved performance (at least in my setup) and reduced memory usage. Please test. I released 2.4.0-beta-4 just now.
Watch this if you are not familiar with BRAT and beta testing plugins: https://youtu.be/2poSS-Z91lY
@zsviczian, I apologize, but i have bad news. I don't see any change in time of export. I've tried several attempts of multiple notes and it ends up with obsidian freezing. I've tried both empty and my personal vault (that I've sent debug info of).
If you would like copies of notes, I can send them through discord to test them yourself, but I don't know how to help more.
Please confirm you are testing 2.4.0-beta-4
Here is a confirmation @zsviczian:
Please try to reproduce the error in a clean vault with only 2.4.0-beta-5 (I made a few further tweaks this morning). In my test environment, there is a very clear and strong performance improvement. So if the same is not true in your environment then we need to understand why the environment is different.
I don't expect that the file you are exporting should be a source of the issue, but if you can share, that can help me verify if the same problem happens on my end.
On a side note. I see you have Editor Syntax Highlight" installed. Based on this issue. I just saw a message by Licat (Obsidian funder) recommending not to use this plugin due to the solutions it includes. I recommend disabling it and then restarting Obsidian. It won't solve the export pdf issue, but at least there is one less potential problem source.
The other "suspicious" plugin is Better PDF Export. I am not familiar with the plugin, but since it is about PDF export and your issue is also with that... just trying to identify the differences.
Obsidian plugins (like Excalidraw) are hobby projects. I see you have 60 plugins enabled. I recommend clearing out those that you don't really use. Each plugin adds custom code that is most often not tested to work with other plugins and can have all sorts of adverse effects. For example, I use 18 plugins, and regularly trim back to list to closer to 10.
BTW - why are you not using live preview? It feels strange to me, as it is one of the best features of the Obsidian editor.
Hello @zsviczian, I've tried to update installer version and created brand new vault for this testing. Only thing that it contains are 5 files, one new created via current version of excalidraw, and 4 previous, and I am still facing the same issue. Here is debug info from this vault:
SYSTEM INFO:
Obsidian version: v1.6.7
Installer version: v1.6.7
Operating system: Windows 11 Home 10.0.22631
Login status: logged in
Catalyst license: none
Insider build toggle: off
Live preview: on
Base theme: adapt to system
Community theme: none
Snippets enabled: 0
Restricted mode: off
Plugins installed: 2
Plugins enabled: 2
1: BRAT v1.0.1
2: Excalidraw v2.4.0-beta-5
RECOMMENDATIONS:
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
So that means that the amount of plugin does not affect export time for me. At least I think. But still I will try to export all files via "Export to PDF command", with stopwatch to see how fast it actually is. I will send you all files to discord (i do not want to share them in public). Here are all files in experiment for export times (from lightest to most heaviest):
Drawing 2024-08-14 18.54.34.excalidraw
(file created in vault) - 7.85 secondsExample of Hybrid Note
- 34.70 secondsHearts
- Stucked in "Preparing for PDF"Model slona a jezdce - New
- Stuck in export, does not even show "Preparing for PDF"Note: While exporting notes, the UI somehow glitches, here is Screenshot:
BTW - why are you not using live preview? It feels strange to me, as it is one of the best features of the Obsidian editor.
I am used to it. Live preview somehow jumps in scroll and that slowed me down in work, now I am used to just press Ctrl + E to switch between Editing mode and Reading mode.
Thanks! The files were not attached.
Thanks! The files were not attached.
I've sent you them on Discord, because I do not want to share them in public. I've attached them there.
Your environment
Describe the bug When I have hybrid note (both Excalidraw and markdown in one file, where i embed areas and frames of drawing into markdown), it takes a long time to export.
To Reproduce
Expected behavior To export faster (in seconds, not in tens or hundreds of seconds).
Screenshots This is screenshot of note that I was trying to export, and it took 20 seconds to export it.
Additional context No additional info. I have to say that your plugin is awesome and I love your work behind it, I appreciate it alot! <3