zsviczian / obsidian-excalidraw-plugin

A plugin to edit and view Excalidraw drawings in Obsidian
4k stars 215 forks source link

BUG: Cannot upload photos into excalidraw #1992

Open Tomsop100 opened 1 week ago

Tomsop100 commented 1 week ago

Have you searched for existing issues (including closed ones)?

Does this bug persist in a new vault with only Excalidraw installed?

Your environment

I am not sure how to run command palette / show debug info - I can't fnd instructions on that.

Describe the bug

I mentioned this bug in a comment to the recent video on YT and Zolt invited me to post the issue here. When I created an empty vault and installed excalidraw only I was unable to reproduce the error. I suppose that means there is an issue with a plug in. I do not have many installed - most of them are common community plug ins. I am open to trying whatever is recommended to try to fix this issue. Thank you.

Steps to reproduce

This happens when I click on the image icon in the toolbar and add an image from photos library, take a picture or add from files. Here is the screenshot of the error I get IMG_0134

Expected behavior

I noticed that when U ran an emply vault the photo when imported would show as pasted within in the Excalidraw folder - I do not see this with my current fault.

Additional context

No response

Tomsop100 commented 1 week ago

I means when I ran the empty vault the photo import worked perfectly and I saw that the photo is referenced as being pasted - I do not see that with the current issue - for some reason Obsidian seems to prevent the phoo3

zsviczian commented 1 week ago

command palette / show debug info: Command Palette is the Obsidian Command Palette (simply press CTRL/CMD+P).

Since I do not see what plugins you have installed I cannot comment. However from the description it seems you have another plugin that is preventing the images from being processed.

Tomsop100 commented 1 week ago

Thank you - here is the debug info - I will try changng the theme:

SYSTEM INFO: Operating system: ios 17.6.1 (Apple iPad14,5) Obsidian version: 1.6.7 (149) API version: v1.6.7 Login status: logged in Catalyst license: none Live preview: on Base theme: light Community theme: Primary v2.8.0 Snippets enabled: 0 Restricted mode: off Plugins installed: 13 Plugins enabled: 12 1: Calendar v1.5.10 2: Quick Switcher++ v4.4.0 3: Tracker v1.14.0 4: HelpMate v1.0.6 5: Bible Reference v3.1.0 6: PDF++ v0.40.9 7: Tasks v7.9.0 8: QuickAdd v1.11.1 9: Templater v2.4.2 10: Dataview v0.5.67 11: Periodic Notes v0.0.17 12: Excalidraw v2.4.1

RECOMMENDATIONS: Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets. Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

zsviczian commented 1 week ago

The error seems to suggest that something interrupts the Excalidraw save operation. This leads me to think that plugins that may be changing data in the background are the first likely candidates for causing this problem.

Try disabling plugins in group 1) below; restart Obsidian and see if Excalidraw works. If yes, try to enable them one by one until Excalidraw breaks. If 1) does not solve the issue try also disabling plugins in 2) and enable them one by one as described earlier. if 2) does not solve the issue, then we likely have some other problem, since the remaining plugins I also have installed.

1) Try disabling only these at first:

2) Less likely candidates:

3) Very unlikely (I also use these):

Tomsop100 commented 1 week ago

Thank you. I tried and now the problem is even with all commmunity plugins disabled except Excalidraw I get the same error. Do I need to uninstall them as well?

zsviczian commented 1 week ago

No, you just need to disable them and restarted Obsidian.

Well, then the next step is to disable the custom there

Tomsop100 commented 1 week ago

I am using the default theme.

zsviczian commented 1 week ago

the debug info says: Community theme: Primary v2.8.0

Tomsop100 commented 1 week ago

I changed to the default theme - still have issues which is strange since the plug in work

SYSTEM INFO: Operating system: ios 17.6.1 (Apple iPad14,5) Obsidian version: 1.6.7 (149) API version: v1.6.7 Login status: logged in Catalyst license: none Live preview: on Base theme: adapt to system Community theme: none Snippets enabled: 0 Restricted mode: off Plugins installed: 12 Plugins enabled: 1 1: Excalidraw v2.4.1

RECOMMENDATIONS: Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

zsviczian commented 1 week ago

But it is not the Primary Theme. I installed it and tested Excalidraw on my iPad. The theme has no impact on this (I would have been surprised). Btw. I love how Primary looks!

So let's better understand what you do. These are the steps you follow? Correct?

image
Tomsop100 commented 1 week ago

I switched to primary theme and still the same issue - yes I did what your screenshots show and it worked with the new vault I created for testing purposes but stll does not work with my existing vault.

zsviczian commented 1 week ago

well.... I am running out of ideas.

Tomsop100 commented 1 week ago

Thanks for all your help - I did delete the plug in earlier. I want to try moving stuff to my new vault and report back - may take a day or so. I was so excited when it worked on my test vault - I did not have much in the folder so I saw the pasted image file in the folder which I never saw when embedding the image with my main vault.

On Wed, Sep 4, 2024 at 8:55 AM zsviczian @.***> wrote:

well.... I am running out of ideas.

  • You could try deleting and installing Excalidraw again.
  • Is this or your other (test) Vault stored in the iCloud? (though I have no idea why that would make a difference)
  • Can you copy your content from the old Vault to the new to see what happens?

— Reply to this email directly, view it on GitHub https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/1992#issuecomment-2329441558, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGHKJQZ2JTME4677GNKEZIDZU4UP3AVCNFSM6AAAAABNTE6EBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGQ2DCNJVHA . You are receiving this because you authored the thread.Message ID: @.***>

zsviczian commented 1 week ago

Did you try attaching different photos from your photo library? Just in case there is a unique issue with the exact photo you are experimenting with...

Tomsop100 commented 1 week ago

I did do that. I thought moving to a new vault would be hard and I discovered it was easier doing the transfer from desktop mac. I forgot all about the desktop so I have no issues with importing from the photos library into Excalidraw though it works differently compared to ipad. But after transferring files to the new vault I confirm it works and after adding back the extensions I wanted - there were a couple I was not really using, I confirmed the embedding works. I even viewed the files from my desktop just to make sure the files showed the photos.

I was so focused on the Ipad I forgot about my desktop app and to tell you I had no issues with the desktop. I rarely use the desktp with Obsidian - usually the Ipad.

Thanks again for your help. It looks like moving to a new vault was the solution for me.

On Wed, Sep 4, 2024 at 9:22 AM zsviczian @.***> wrote:

Did you try attaching different photos from your photo library? Just in case there is a unique issue with the exact photo you are experimenting with...

— Reply to this email directly, view it on GitHub https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/1992#issuecomment-2329498064, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGHKJQ2U567VMGKCQWCSJNTZU4XVJAVCNFSM6AAAAABNTE6EBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGQ4TQMBWGQ . You are receiving this because you authored the thread.Message ID: @.***>

HoodyEz commented 1 week ago

i has the same problem but i fixed it when i deleted the template of excalidraw and created a new one

zsviczian commented 1 week ago

@HoodyEz do you still have your old template? Can you share?

HoodyEz commented 1 week ago

hummmmm noup, i deleted :(