Closed ChristofferNorgaard closed 1 year ago
Great! Once you have improvements for the apple pencil let's implement them in the Obsidian fork as well. Instead of working with the Obsidian fork you might be better off forking the excalidraw main product. If you get additional features for apple pencil developed there it will be easy to bring them into the obsidian fork. Also if I do developments to the core package I always try to make the changes to excalidraw.com because that way my enhancements are available to others as well, and when the package changes, my changes are considered as well.
If you still want to build the obsidian version you need to fork two projects, this and this.
Have you noticed the comments I have in rollup.js? you need to apply these. //!postprocess - the version available on npmjs does not work, need this update: // npm install brettz9/rollup-plugin-postprocess#update --save-dev // https://github.com/developit/rollup-plugin-postprocess/issues/10
Other then these comments and the need to build both projects (the for-obsidian excalidraw package and the plugin project), there should be nothing additional required. I build on Windows - you may need to modify scripts in package.json to work with your operating system.
Ok, thank you for information.
I want to debug https://github.com/zsviczian/obsidian-excalidraw-plugin/issues/1814 which is presumably happening only in my machine, so I tried to follow the build instruction described here (since I had the same issue as @ChristofferNorgaard for npm not being able to resolve import "colormaster/plugins/luv"). However, I cannot resolve the issue, so I guess there's something I'm doing wrong. I would really really appreciate it if any of you could help me for a successful build. Here are the steps I tried following @zsviczian 's reply above:
.obsidian/plugins/
.
1.1 For excalidraw, switch to for-obsidian
branchnpm install
in both excalidraw and obsidian-excalidraw-plugin.obsidian-excalidraw-plugin
directory, run npm install brettz9/rollup-plugin-postprocess#update --save-dev
.npm run build
in both excalidraw and obsidian-excalidraw-plugin.
4.1. For excalidraw, run export NODE_OPTIONS=--openssl-legacy-provider
before build. Otherwise, I get Error: error:0308010C:digital envelope routines::unsupported
obsidian-excalidraw-plugin
directory, and copy ./dist/main.js
to ./main.js
.After 7 above, I get Plugin failure: obsidian-excalidraw-plugin Error: Cannot find module 'colormaster/plugins/luv'
in Obsidian Developer console, which is because of npm was not able to resolve import "colormaster/plugins/luv", I guess.
I'm not familiar with the entire Javascript ecosystem, and that's probably why I'm having these difficulties. I would really really appreciate if you could help me figure out the issue!
node version: v18.19.1 Operating system: Ubuntu 22.04
Hi.
I am modifying excalidraw to be a bit more usable with apple pen and am trying to build obsidian excalidraw plugin.
Are there any instructions how to build this? Any node or yarn versions and so on...
I am having a bit of trouble with rollup and colormaster and I think it may be a version problem.
Thanks for all the good work on the project.