search

ztalbot2000 / homebridge-cmd4

CMD4 Plugin for Homebridge - Supports ~All Accessory Types & now all Characteristics too
Apache License 2.0
145 stars 14 forks source link

Documentation: Dead Link https://github.com/ztalbot2000/homebridge-cmd4#source-code #95

Closed jsiegenthaler closed 3 years ago

jsiegenthaler commented 3 years ago

Describe The Bug: In this section of the documentation: https://github.com/ztalbot2000/homebridge-cmd4#contributing

There is a dead link in this sentence: Submit fixes and/or improvements with Pull Requests

The text Pull Requests has this url embedded: https://github.com/ztalbot2000/homebridge-cmd4#source-code

The URL is a dead link, it does not open

ztalbot2000 commented 3 years ago

Odd, it passes link-checker or nothing will submit. I'll have a look tomorrow.

On Wed, Feb 24, 2021 at 11:40 PM jsiegenthaler notifications@github.com wrote:

Assigned #95 https://github.com/ztalbot2000/homebridge-cmd4/issues/95 to @ztalbot2000 https://github.com/ztalbot2000.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ztalbot2000/homebridge-cmd4/issues/95#event-4374491312, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSBCX2AED7IZ2G7MIGIL3DTAXIETANCNFSM4YFY747Q .

ztalbot2000 commented 3 years ago

HaHa, Pull Request dead link is a zero day bug. Great find. I also think the link checker does not handle relative links. It only checks the base url :-(

On Wed, Feb 24, 2021 at 11:58 PM John Talbot ztalbot2000@gmail.com wrote:

Odd, it passes link-checker or nothing will submit. I'll have a look tomorrow.

On Wed, Feb 24, 2021 at 11:40 PM jsiegenthaler notifications@github.com wrote:

Assigned #95 https://github.com/ztalbot2000/homebridge-cmd4/issues/95 to @ztalbot2000 https://github.com/ztalbot2000.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ztalbot2000/homebridge-cmd4/issues/95#event-4374491312, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSBCX2AED7IZ2G7MIGIL3DTAXIETANCNFSM4YFY747Q .

ztalbot2000 commented 3 years ago

Resolved a while ago. I fixed one. The sentence was deleted in the other.