search

ztalbot2000 / homebridge-cmd4

CMD4 Plugin for Homebridge - Supports ~All Accessory Types & now all Characteristics too
Apache License 2.0
149 stars 13 forks source link

[Bug] Matching Target Characteristic for Current Characteristic Warning #96

Closed mitch7391 closed 3 years ago

mitch7391 commented 3 years ago

Describe The Bug:

Hey John, I know you did some recent work around making sure all 'Current' characteristics (e.g. CurrentTemperature) has a matching 'Target' characteristic (e.g TargetTemperature). However in some cases like my temperature sensors, they do not have a characteristic for target. You can confirm that here.

To Reproduce:

Restart Homebridge and the warnings will appear in the logs.

Expected Behaviour:

cmd4 should not be trying to make TargetTemperature for temperature sensors and the warnings should not be coming up.

Paste of Logs:

[27/02/2021, 08:35:32] [Cmd4] Warning, With fetch set to "Always" and polling for "CurrentTemperature" requested, you also must do polling of "TargetTemperature" or things will not function properly

Environment:

ztalbot2000 commented 3 years ago

Hey Mitch,

If you go from the Home app and set the temperature, What is sent is by the home app is to set TargetTemperature. Not current temperature.

Ooh, maybe a sensor is different. There it only asks for currentTemperature and then the log does not apply. Ok I can fix that. Neede to check device type for warning message.

TTFN, John

On Fri, Feb 26, 2021 at 7:48 PM Mitch Williams notifications@github.com wrote:

Assigned #96 https://github.com/ztalbot2000/homebridge-cmd4/issues/96 to @ztalbot2000 https://github.com/ztalbot2000.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ztalbot2000/homebridge-cmd4/issues/96#event-4384338292, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSBCX56X3ZXWXJLYZ7K6TDTBA6NFANCNFSM4YJLJPQA .

mitch7391 commented 3 years ago

If you go from the Home app and set the temperature, What is sent is by the home app is to set TargetTemperature. Not current temperature.

Yep that makes sense.

Ooh, maybe a sensor is different. There it only asks for currentTemperature and then the log does not apply.

Spot on the money :) I am not sure what other accessories might not need a 'target', but it might be worth checking all sensor type services for other people's accessories too.

ztalbot2000 commented 3 years ago

Working on it. The related characteristic must be in the same required or optional characteristics of the device.

TTFN, John

On Fri, Feb 26, 2021 at 8:17 PM Mitch Williams notifications@github.com wrote:

If you go from the Home app and set the temperature, What is sent is by the home app is to set TargetTemperature. Not current temperature.

Yep that makes sense.

Ooh, maybe a sensor is different. There it only asks for currentTemperature and then the log does not apply.

Spot on the money :) I am not sure what other accessories might not need a 'target', but it might be worth checking all sensor type services for other people's accessories too.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ztalbot2000/homebridge-cmd4/issues/96#issuecomment-786975259, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSBCXYBF5OKEMB6BGI5HR3TBBB4LANCNFSM4YJLJPQA .

ztalbot2000 commented 3 years ago

released as part of v3.3.0