search

ztane / python-Levenshtein

The Levenshtein Python C extension module contains functions for fast computation of Levenshtein distance and string similarity
GNU General Public License v2.0
1.26k stars 155 forks source link

incorrect setuptools dependency #79

Open 0-wiz-0 opened 2 years ago

0-wiz-0 commented 2 years ago

setuptools is listed as an install_requires in setup.py, but the installed library does not use it nor pkg_resources. I think this is at most a setup_requires.

dhgutteridge commented 2 years ago

Separately, the entry_points definition in setup.py can also be problematic. Being empty, it doesn't actually serve any purpose as I understand it, but it causes different packaging behaviour with setuptools >=60.9 than before (entry_points.txt now gets removed, but is retained as an empty file with older versions). This complicates matters for downstream packagers who support both Python 2.7 (using setuptools 44) and recent releases.