ztellman / automat

better automata through combinators

588 stars 50 forks source link

Delay cljs.compiler/emit-constant registration until CLJS compile-time #69

Closed cemerick closed 7 years ago

cemerick commented 7 years ago

fixes #68

ztellman commented 7 years ago

Great, thank you. Would you like me to cut a release with this fix?

cemerick commented 7 years ago

Ah, sure, that'd be great. I have an artifact up for people to test, but it's really a pretty straightforward change. (Though I have some theories, why the change is needed is a complete mystery to me.)

cemerick commented 7 years ago

FYI, I believe the first release where this became a problem is CLJS 1.9.671. The prior approach was fine with AOT for earlier releases; the suggested change should be good for approximately any 1.9.x release.

cemerick commented 7 years ago

Hold up on a release. This doesn't play nicely with CLJS advanced optimizations.

tangrammer commented 7 years ago

Hi there :) any progress related with the advanced optimizations ... @cemerick maybe you want to extend here the details of your current path?

cemerick commented 7 years ago

70 resolves the problem entirely, just needs merging. Been using the result of that for a couple of weeks now with good results.

tangrammer commented 7 years ago

Great, thanks a lot!

ztellman commented 7 years ago

Sorry for the delay, I've merged the change and cut a new release On Fri, Sep 15, 2017 at 8:28 AM Juan A. Ruz notifications@github.com wrote:

Great, thanks a lot!

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/ztellman/automat/pull/69#issuecomment-329815938, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB6P25RX0KMwslpOtN7_PXLxAUeT1teks5sipeKgaJpZM4PEoa1 .