break and continue missing, swizzled l-value assignment bug in GLSL

ztellman / penumbra

not under active development - idiomatic opengl bindings for clojure

354 stars 43 forks source link

break and continue missing, swizzled l-value assignment bug in GLSL #31

Closed snoury closed 13 years ago

snoury commented 13 years ago

Hi Zach,

I've been playing a bit with penumbra and found some minor bugs in the GLSL translation layer:

the loop break and continue operators were missing
the assignment to a swizzled l-value didn't translate correctly: (*= (.rgb sample-color) light-coef) gave sample-color.rgb *= light_coef; instead of sample_color.rgb *= light_coef;.

Thanks for your awesome project, it motivated me enough to finally give clojure a try :)

Cheers, Sebastien

ztellman commented 13 years ago

Cool, thank you. That parsing code needs to be torn down and rewritten some day soon. If you want to delve into the code base and have any questions, I'm always available.