search

ztgrace / changeme

A default credential scanner.
GNU General Public License v3.0
1.44k stars 248 forks source link

Creds: Kanboard 1.0.37 #20

Closed ThomasTJdev closed 7 years ago

ThomasTJdev commented 7 years ago

Kanboard 1.0.37

Current creds for Kanboard, kanboard.yml, does not work on the newest release of Kanboard 1.0.37.

Problem & Solution

After Kanboards upgrade (May 28, 2016 - 1353929a7dbd3f2e897fa7d3ab88e959ca573f9f) the authentication controller has been renamed from: auth to AuthController

There is nothing in the body which matches the current <title>Dashboard</title> therefore I have changed this to: Dashboard for admin.

Further development

@ztgrace - What are your thoughts on multiple versions/releases of the same software? Should these new versions be included in the same file, or would you like multiple files like this pull?

ztgrace commented 7 years ago

@ThomasTJdev thanks for the PR! I'm in the middle of finishing up refactoring changeme and will pull this in after I merge that branch into master.

Good question on how to handle multiple versions. For instances like yours where portions that changed are already a list type in the cred yaml, we'd be able add additional items to the list without needing to create a separate file (see the example below). I should also have a way to denote version numbers associated with the creds; I'll probably add that to the schema soon.

  url:
   - /?controller=auth&action=check
   - /?controller=AuthController&action=check
   - /kanboard/?controller=AuthController&action=check

Thanks, Zach