Fix cleaning up of ReplaySubjects as they have been consumed

zth / rescript-relay-router

MIT License

16 stars 3 forks source link

Fix cleaning up of ReplaySubjects as they have been consumed #32

Closed zth closed 2 years ago

zth commented 2 years ago

ReplaySubject's are used to replay Relay data that was retrieved server side, client side. This is how shipping data from the server to the client is handled. However, we need to determine when a replay subject is cleaned up/removed (so it's not accidentally used again when we want fresh data from the API via the client), and this is slightly messy for various reasons.

zth commented 2 years ago

There's code for this which I believe is working. Closing this now, but one of the following two things will need to happen:

Add actual tests that test this behavior
Test this more thoroughly with a better test setup than the current test app is

Will revisit later.