search

zth / rescript-relay

Use Relay with ReScript.
https://rescript-relay-documentation.vercel.app/docs/getting-started
338 stars 53 forks source link

Remove dependency on reason-promise #209

Closed zth closed 3 years ago

zth commented 3 years ago

This was a bad idea to depend on from the beginning (my mistake!), and since it's only used in very few places, we should go ahead and just remove it. It's a breaking change though sadly, but it's for the greater good.

zth commented 3 years ago

Will wait for this to land before proceeding here.

cometkim commented 3 years ago

I tried to use ReScript-JS, which is depending on ReScirpt Promise

And ReScript Promise and Reason Promise both are use Promise module without namespace :sweat_smile:

zth commented 3 years ago

Update: Since the core team haven't shipped the new bindings yet, we'll revert from rescript-promise back to Js.Promise so people can use the new bindings if they want.